Skip to content

feat: Add href to action card#4682

Open
SpyZzey wants to merge 5 commits into
mainfrom
feat/href-in-action-card
Open

feat: Add href to action card#4682
SpyZzey wants to merge 5 commits into
mainfrom
feat/href-in-action-card

Conversation

@SpyZzey

@SpyZzey SpyZzey commented Jul 1, 2026

Copy link
Copy Markdown
Member

Description

Adds href to the action card.

Related links, issue #, if available: cvz6736uKl03

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SpyZzey SpyZzey requested a review from a team as a code owner July 1, 2026 12:54
@SpyZzey SpyZzey requested review from georgylobko and removed request for a team July 1, 2026 12:54
@SpyZzey SpyZzey removed the request for review from georgylobko July 1, 2026 13:11
@SpyZzey SpyZzey marked this pull request as draft July 1, 2026 13:11
@SpyZzey SpyZzey changed the title Feat/href in action card feat: Add href to action card Jul 1, 2026
Comment thread src/action-card/__tests__/action-card.test.tsx
Comment thread src/action-card/internal.tsx Outdated
Comment thread src/action-card/internal.tsx Outdated
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.57%. Comparing base (e4c3d49) to head (0ea3505).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4682   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         948      948           
  Lines       30517    30529   +12     
  Branches    11168    11173    +5     
=======================================
+ Hits        29777    29789   +12     
  Misses        693      693           
  Partials       47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

expect(wrapper.getElement().querySelector('button')).toBeNull();
});

test('disabled link stays focusable and announced as a link', () => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it focusable when disabled?

@SpyZzey SpyZzey Jul 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matches the current behavior in Action card with button tag.

@SpyZzey SpyZzey added this pull request to the merge queue Jul 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 9, 2026
@SpyZzey SpyZzey added this pull request to the merge queue Jul 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants